gianm commented on a change in pull request #9662: fix issue with group by
limit pushdown for extractionFn, expressions, joins, etc
URL: https://github.com/apache/druid/pull/9662#discussion_r406911065
##########
File path:
processing/src/main/java/org/apache/druid/segment/DimensionHandlerUtils.java
##########
@@ -61,6 +61,8 @@ private DimensionHandlerUtils()
public static final ColumnCapabilities DEFAULT_STRING_CAPABILITIES =
new ColumnCapabilitiesImpl().setType(ValueType.STRING)
.setDictionaryEncoded(true)
+ .setDictionaryValuesUnique(true)
Review comment:
This doesn't seem right. The only place using `DEFAULT_STRING_CAPABILITIES`
is `getEffectiveCapabilities` in this same file. And looking at the cases in
that method, each one seems like it should behave a bit differently. So
consider deleting this constant and having the `getEffectiveCapabilities`
should be generating various capabilities objects.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
