gianm commented on a change in pull request #9662: fix issue with group by
limit pushdown for extractionFn, expressions, joins, etc
URL: https://github.com/apache/druid/pull/9662#discussion_r406907301
##########
File path:
processing/src/main/java/org/apache/druid/query/groupby/epinephelinae/GroupByQueryEngineV2.java
##########
@@ -707,6 +719,33 @@ protected void putToRow(ByteBuffer key, ResultRow
resultRow)
);
}
}
+
+ /**
+ * check if a collection of columns will operate correctly with {@link
LimitedBufferHashGrouper} for query limit
+ * pushdown
+ */
+ private boolean canPushdownLimit(Stream<String> columnNames)
Review comment:
IMO it's more elegant if this method doesn't exist, and the caller does the
allMatch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
