gianm commented on a change in pull request #9662: fix issue with group by
limit pushdown for extractionFn, expressions, joins, etc
URL: https://github.com/apache/druid/pull/9662#discussion_r407028521
##########
File path:
processing/src/main/java/org/apache/druid/query/groupby/epinephelinae/column/StringGroupByColumnSelectorStrategy.java
##########
@@ -148,7 +153,12 @@ private void initializeGroupingKeyV2Dimension(
@Override
public Grouper.BufferComparator bufferComparator(int keyBufferPosition,
@Nullable StringComparator stringComparator)
{
- if (stringComparator == null ||
StringComparators.LEXICOGRAPHIC.equals(stringComparator)) {
+ final boolean canCompareInts =
+ capabilities != null &&
+ capabilities.hasBitmapIndexes() &&
Review comment:
Bitmap indexes aren't required here. I don't think it hurts too much to have
in practice this check here, since in the primary case where pushdown matters
(direct access to a column in a regular segment) bitmap indexes will be there.
But it isn't necessary.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
