suneet-s commented on a change in pull request #9760:
URL: https://github.com/apache/druid/pull/9760#discussion_r414905804
##########
File path:
processing/src/main/java/org/apache/druid/segment/join/lookup/LookupJoinMatcher.java
##########
@@ -277,7 +277,7 @@ public void matchRemainder()
} else {
currentIterator = Iterators.filter(
extractor.iterable().iterator(),
- entry -> !matchedKeys.contains(entry.getKey())
+ entry -> entry != null && !matchedKeys.contains(entry.getKey())
Review comment:
It doesn't look like this can actually happen, I think.
In theory iterator.next() can return null, but `MapLookupExtractor#iterable`
(the only implementation today that does not throw an exception) returns
`map.entrySet()` which should never contain a null element.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
