jihoonson commented on a change in pull request #9760:
URL: https://github.com/apache/druid/pull/9760#discussion_r416985934
##########
File path:
processing/src/main/java/org/apache/druid/segment/join/lookup/LookupJoinMatcher.java
##########
@@ -277,7 +277,7 @@ public void matchRemainder()
} else {
currentIterator = Iterators.filter(
extractor.iterable().iterator(),
- entry -> !matchedKeys.contains(entry.getKey())
+ entry -> entry != null && !matchedKeys.contains(entry.getKey())
Review comment:
Yeah. It also doesn't seem reasonable that a "row" can be null. I think
it's a false warning because of the `Predicate` interface of Guava. It would be
better to suppress warning instead of checking null.
##########
File path:
processing/src/main/java/org/apache/druid/segment/virtual/MultiValueExpressionDimensionSelector.java
##########
@@ -50,11 +50,13 @@ public
MultiValueExpressionDimensionSelector(ColumnValueSelector<ExprEval> baseS
this.baseSelector = baseSelector;
}
+ @Nullable
Review comment:
Does all callers need to check the returned eval? Seems there are a
couple of missing places.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
