suneet-s commented on a change in pull request #9760:
URL: https://github.com/apache/druid/pull/9760#discussion_r416992856
##########
File path:
processing/src/main/java/org/apache/druid/segment/join/lookup/LookupJoinMatcher.java
##########
@@ -277,7 +277,7 @@ public void matchRemainder()
} else {
currentIterator = Iterators.filter(
extractor.iterable().iterator(),
- entry -> !matchedKeys.contains(entry.getKey())
+ entry -> entry != null && !matchedKeys.contains(entry.getKey())
Review comment:
good call. Looks like this is on a hot path too, so I've added an
inspection suppression instead of an assert not null. 👍
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
