suneet-s commented on a change in pull request #10091:
URL: https://github.com/apache/druid/pull/10091#discussion_r447323292
##########
File path: services/src/main/java/org/apache/druid/cli/ServerRunnable.java
##########
@@ -194,15 +202,40 @@ private DiscoverySideEffectsProvider(
this.useLegacyAnnouncer = useLegacyAnnouncer;
}
+ @VisibleForTesting
+ DiscoverySideEffectsProvider(
Review comment:
I'd need to refactor this to use Guice's AssistedInject Factory to avoid
having 2 constructors - It's why I don't really like injected field members.
If you think it's worth the refactoring, I can make that change. I'll wait
to see if there are any other comments before pushing up a new patch
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
