suneet-s commented on a change in pull request #10091:
URL: https://github.com/apache/druid/pull/10091#discussion_r447338506
##########
File path: services/src/main/java/org/apache/druid/cli/ServerRunnable.java
##########
@@ -194,15 +202,40 @@ private DiscoverySideEffectsProvider(
this.useLegacyAnnouncer = useLegacyAnnouncer;
}
+ @VisibleForTesting
+ DiscoverySideEffectsProvider(
+ final NodeRole nodeRole,
+ final List<Class<? extends DruidService>> serviceClasses,
+ final boolean useLegacyAnnouncer,
+ final DruidNode druidNode,
+ final DruidNodeAnnouncer announcer,
+ final ServiceAnnouncer legacyAnnouncer,
+ final Lifecycle lifecycle,
+ final Injector injector
+ )
+ {
+ this.nodeRole = nodeRole;
+ this.serviceClasses = serviceClasses;
+ this.useLegacyAnnouncer = useLegacyAnnouncer;
+ this.druidNode = druidNode;
+ this.announcer = announcer;
+ this.legacyAnnouncer = legacyAnnouncer;
+ this.lifecycle = lifecycle;
+ this.injector = injector;
+ }
+
@Override
public Child get()
{
ImmutableMap.Builder<String, DruidService> builder = new
ImmutableMap.Builder<>();
for (Class<? extends DruidService> clazz : serviceClasses) {
DruidService service = injector.getInstance(clazz);
- builder.put(service.getName(), service);
+ if (service.isDiscoverable()) {
+ builder.put(service.getName(), service);
+ } else {
+ log.info("Service[%s] is not discoverable", service.getName());
Review comment:
Done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
