suneet-s commented on a change in pull request #10091:
URL: https://github.com/apache/druid/pull/10091#discussion_r447338227
##########
File path: server/src/main/java/org/apache/druid/guice/StorageNodeModule.java
##########
@@ -74,17 +82,36 @@ public DruidServerMetadata getMetadata(
@Provides
@LazySingleton
- public DataNodeService getDataNodeService(@Nullable ServerTypeConfig
serverTypeConfig, DruidServerConfig config)
+ public DataNodeService getDataNodeService(
+ @Nullable ServerTypeConfig serverTypeConfig,
+ DruidServerConfig config,
+ @Named(IS_SEGMENT_CACHE_CONFIGURED) Boolean isSegmentCacheConfigured
+ )
{
if (serverTypeConfig == null) {
- throw new ProvisionException("Must override the binding for
ServerTypeConfig if you want a DruidServerMetadata.");
+ throw new ProvisionException("Must override the binding for
ServerTypeConfig if you want a DataNodeService.");
+ }
+ if (!isSegmentCacheConfigured) {
+ log.info("Segment cache not configured on ServerType [%s]",
serverTypeConfig.getServerType());
Review comment:
Done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
