jihoonson commented on a change in pull request #10171:
URL: https://github.com/apache/druid/pull/10171#discussion_r459062590
##########
File path: integration-tests/docker/druid.sh
##########
@@ -82,14 +83,18 @@ setupData()
# The "query" and "security" test groups require data to be setup before
running the tests.
# In particular, they requires segments to be download from a pre-existing
s3 bucket.
# This is done by using the loadSpec put into metadatastore and s3
credientials set below.
- if [ "$DRUID_INTEGRATION_TEST_GROUP" = "query" ] || [
"$DRUID_INTEGRATION_TEST_GROUP" = "security" ]; then
+ if [ "$DRUID_INTEGRATION_TEST_GROUP" = "query" ] || [
"$DRUID_INTEGRATION_TEST_GROUP" = "query-retry" ] || [
"$DRUID_INTEGRATION_TEST_GROUP" = "security" ]; then
Review comment:
What is the main use case of the flag system? As what each test group
needs are fixed (e.g., hadoop cluster must be started for hadoop task test),
I'm not sure how it's better compared to that the docker script automatically
launches necessary things depending on the test group.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
