jihoonson commented on a change in pull request #10171:
URL: https://github.com/apache/druid/pull/10171#discussion_r459074866
##########
File path: integration-tests/docker/druid.sh
##########
@@ -82,14 +83,18 @@ setupData()
# The "query" and "security" test groups require data to be setup before
running the tests.
# In particular, they requires segments to be download from a pre-existing
s3 bucket.
# This is done by using the loadSpec put into metadatastore and s3
credientials set below.
- if [ "$DRUID_INTEGRATION_TEST_GROUP" = "query" ] || [
"$DRUID_INTEGRATION_TEST_GROUP" = "security" ]; then
+ if [ "$DRUID_INTEGRATION_TEST_GROUP" = "query" ] || [
"$DRUID_INTEGRATION_TEST_GROUP" = "query-retry" ] || [
"$DRUID_INTEGRATION_TEST_GROUP" = "security" ]; then
Review comment:
> If your concern is about code complexity, then we could provide a
developer-friendly configuration where we can easily add or remove test groups
which our docker script can handle in a more structured way.
Yeah, this comment above was to provide developer-friendly configurations so
that they can easily add new integration tests. I guess what I think is pretty
similar to yours, something like a centralized configuration system where you
can define what you need for your integration test so that you don't have to
worry about flags or configs at test run time. What I'm not sure is if they
should be runtime flags. Maybe they could be if it's easier to implement.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
