maytasm commented on a change in pull request #10171:
URL: https://github.com/apache/druid/pull/10171#discussion_r459067717
##########
File path: integration-tests/docker/druid.sh
##########
@@ -82,14 +83,18 @@ setupData()
# The "query" and "security" test groups require data to be setup before
running the tests.
# In particular, they requires segments to be download from a pre-existing
s3 bucket.
# This is done by using the loadSpec put into metadatastore and s3
credientials set below.
- if [ "$DRUID_INTEGRATION_TEST_GROUP" = "query" ] || [
"$DRUID_INTEGRATION_TEST_GROUP" = "security" ]; then
+ if [ "$DRUID_INTEGRATION_TEST_GROUP" = "query" ] || [
"$DRUID_INTEGRATION_TEST_GROUP" = "query-retry" ] || [
"$DRUID_INTEGRATION_TEST_GROUP" = "security" ]; then
Review comment:
I believe it might be easier for a person who does not know the internal
working of our Docker/Compose scripts to write new integration tests. Basically
you do not need to know where all the bit and pieces are like to preload the
data you need to modify the if check in druid.sh, and to do other stuff maybe
we in other places, etc.
For example, if I want to write a new integration test group that requires
pre load data and hadoop running and maybe indexer running instead of MM, all
of that might be in 3 different places in different files. With the flag
system, you just need to specify what you want in the travis file for the mvn
cmd.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
