vogievetsky commented on a change in pull request #10256: URL: https://github.com/apache/druid/pull/10256#discussion_r467331434
########## File path: web-console/src/dialogs/spec-dialog/__snapshots__/spec-dialog.spec.tsx.snap ########## @@ -1,6 +1,187 @@ // Jest Snapshot v1, https://goo.gl/fbAQLP -exports[`spec dialog matches snapshot 1`] = ` +exports[`spec dialog matches snapshot no initSpec 1`] = ` Review comment: none of the tests (and test aids like this one) are included in the bundle because none of the code depends on any of the test code (if it did then it would not compile because tests run in a different environment `jest` than the prod code `node/dom`). In general the web console follows a standard where every class (or functional component) lives in a file next to the style and the test  ... this has been the case from day one (of the unified console) and is pretty idiomatic of the modern web-dev world. The tests are separated from the code with file extensions `*.spec.*` vs location ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
