gianm commented on a change in pull request #10256:
URL: https://github.com/apache/druid/pull/10256#discussion_r467332588
##########
File path: web-console/src/components/json-input/json-input.tsx
##########
@@ -24,7 +24,9 @@ import AceEditor from 'react-ace';
import './json-input.scss';
function parseHjson(str: string) {
- return str === '' ? null : Hjson.parse(str);
+ // Throwing on empty input is more consistent with how JSON.parse works
Review comment:
Thanks for the detailed explanation!!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
