abhishekagarwal87 commented on a change in pull request #10267:
URL: https://github.com/apache/druid/pull/10267#discussion_r469190573
##########
File path:
indexing-service/src/main/java/org/apache/druid/indexing/input/DruidInputSource.java
##########
@@ -87,13 +91,21 @@
@Nullable
private final List<WindowedSegmentId> segmentIds;
private final DimFilter dimFilter;
Review comment:
will it make sense to move DimFilter outside the InputSource in the task
json? It seems more natural to me to put the filters alongside transforms,
dimensions, and metrics and leave only the data source properties inside the
`InputSource` section. On the flip side, it could make the compatibility
situation more complicated than it is.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
