gianm commented on pull request #10267: URL: https://github.com/apache/druid/pull/10267#issuecomment-679860018
@jon-wei I've pushed a new commit. > That sounds fine to me too, I don't really have a strong preference on that. > > Hmm, thinking about this some more, it may be best to not have it be an error. The risk of doing a sanity-check error is that something that worked before will stop working once you upgrade. It seems to me that any time someone had been specifying dimensions and metrics manually, but not including all input fields, they probably didn't do that intentionally. So this should be a bug fix that they appreciate, even though it's a behavioral change. > > That sounds fine to me too, I don't really have a strong preference on that. For this one, I left it as not-an-error. > Ah, I was thinking that the auto/millis check in the new mode would only apply if the column being referenced was `__time`, so that users could still use alternate timestamp columns. > > The warning log sounds fine to me. For this one, I added a config `druid.indexer.task.ignoreTimestampSpecForDruidInputSource` that defaults off (false). If enabled, timestampSpecs are ignored with the 'druid' input source, and a warning is logged each time a reader is created. Either way, a warning is logged if you read from the `__time` column with a format other than `millis` or `auto`. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
