jon-wei commented on pull request #10267:
URL: https://github.com/apache/druid/pull/10267#issuecomment-673733953


   > For (1) we could throw an error in situations where people explicitly 
specify dimensions and metrics that don't match the computed inputs, informing 
them that these parameters no longer have an effect and asking them to remove 
them.
   
   (1) sounds good to me.
   
   > For (3) we could introduce a flag that causes an error to be thrown when 
you set the timestamp spec to anything other than {"column": "__time", 
"format": "auto"} or {"column": "__time", "format": "millis"}. Druid would 
invite you to set the flag, which would tell it "yes I really want the new, 
more correct behavior". That feature flag could be on or off by default.
   
   I think I'm a little unclear on (3), is the feature flag controlling whether 
to use the old/new behavior or is it just for whether the auto/millis check is 
executed? 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to