clintropolis commented on a change in pull request #10219:
URL: https://github.com/apache/druid/pull/10219#discussion_r469536567
##########
File path:
processing/src/main/java/org/apache/druid/query/metadata/SegmentAnalyzer.java
##########
@@ -100,6 +100,11 @@ public long numRows(Segment segment)
Map<String, ColumnAnalysis> columns = new TreeMap<>();
+ Function<String, ColumnCapabilities> adapterCapabilitesFn =
Review comment:
eh, I think introduced the ugly `instanceof` in the first place in a
previous PR to fix a different bug. I have a plan to not need this, since it is
only necessary for incremental index adapter, so I hope this code is rather
temporary but the changes are too big to be part of this patch.
I would rather not introduce a new method to storage adapter specifically
for incremental index adapter, and would prefer to address it when I eliminate
the need for it, if that is cool with you. If you disagree and feel strongly
about it though, I can introduce a temporary method for it now, and just remove
it in the follow-up.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
