clintropolis commented on a change in pull request #10219:
URL: https://github.com/apache/druid/pull/10219#discussion_r469539265
##########
File path:
processing/src/main/java/org/apache/druid/segment/column/ColumnCapabilities.java
##########
@@ -38,6 +38,7 @@
boolean hasSpatialIndexes();
Capable hasMultipleValues();
boolean isFilterable();
+ Capable isNullable();
Review comment:
I agree, and have renamed this to `hasNulls`, but haven't changed the
segment metadata `ColumnAnalysis` yet...
I view segment metadata as the computed equivalent of an SQL schema, and
have exposed in with the intention of populating the `IS_NULLABLE` column in
the information schema columns table, and access via `DruidSchema` will allow
the SQL planner to make better plans and skip null checking and such, so I
thought it still appropriate to leave this as `isNullable`. I don't feel super
strongly about this though, so if you disagree I can change it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
