clintropolis commented on a change in pull request #10219:
URL: https://github.com/apache/druid/pull/10219#discussion_r469539597
##########
File path:
processing/src/main/java/org/apache/druid/segment/serde/DictionaryEncodedColumnPartSerde.java
##########
@@ -329,6 +331,7 @@ public void read(ByteBuffer buffer, ColumnBuilder builder,
ColumnConfig columnCo
);
builder
.setHasMultipleValues(hasMultipleValues)
+ .setNullable(firstDictionaryEntry == null)
Review comment:
I modified the test to cover this condition, it still reports as having
nulls if it ingests an empty list to a multi-value column.
##########
File path:
processing/src/main/java/org/apache/druid/segment/serde/DictionaryEncodedColumnPartSerde.java
##########
@@ -329,6 +331,7 @@ public void read(ByteBuffer buffer, ColumnBuilder builder,
ColumnConfig columnCo
);
builder
.setHasMultipleValues(hasMultipleValues)
+ .setNullable(firstDictionaryEntry == null)
Review comment:
I modified a column capabilities test to cover this condition, it still
reports as having nulls if it ingests an empty list to a multi-value column.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
