clintropolis opened a new pull request #10272: URL: https://github.com/apache/druid/pull/10272
Fixes #7931. ### Description This PR fixes an issue when using JDBC prepared statements through a router. [Per the docs](https://calcite.apache.org/avatica/docs/json_reference.html#requests), all requests either have a top level `connectionId`, or, if part of a prepared statement, the `connectionId` might be nested in a `statementHandle`, so the router will now check for this case. There are probably more magical ways to do this, but this was the most straightforward. Integration tests have been added to test JDBC metadata, statements, and prepared statements to make sure things work on both brokers and routers. The prepared statement query test fails prior to the changes in this patch. <hr> This PR has: - [x] been self-reviewed. - [ ] added documentation for new or modified features or behaviors. - [x] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader. - [ ] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met. - [x] added integration tests. - [x] been tested in a test Druid cluster. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
