vogievetsky opened a new pull request #10271: URL: https://github.com/apache/druid/pull/10271
Fixed and improved the JSON Input component (as seen in the Edit Spec step of the data loader) Specifically fixed the issue with the JSON input sometimes moving the cursor when editing, fixed the undo stack. The fix is based around maintaining the state of the JSON Input in a single state variable (`InternalValue`) and thus not letting it get desynchronized. While at it I also added a nice error display in case there is an issue with the JSON  Clicking on it takes your cursor to the place with the error which is sweet - doing this required me to nest the Ace editor inside a div which causes a lot of snapshot diffs. Also updated the snapshots for all the users of JSON Input to shallow render so in the future they would be immune to JSON Input structure changes. This PR has: - [x] been self-reviewed. - [x] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links - [x] added unit tests or modified existing tests to cover new code paths - [x] been tested in a test Druid cluster. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
