vogievetsky commented on a change in pull request #10271:
URL: https://github.com/apache/druid/pull/10271#discussion_r470076284
##########
File path:
web-console/src/components/auto-form/__snapshots__/auto-form.spec.tsx.snap
##########
@@ -2,521 +2,135 @@
exports[`auto-form snapshot matches snapshot 1`] = `
<div
- class="auto-form"
Review comment:
That is correct.
Here is how I review them:
```
The snapshot change is either tiny or structural (huge) there is no in
between.
If the change is tiny:
Review the changed lines and understand what caused that change. Was a
class or some other property added / removed? Does it make sense?
If the change is structural:
Do not review the individual lines, only review which snapshot files
changed. Does it make sense that the snapshot of this component changed so
drastically?
```
In this case all the changes are structural. I have wrapped the JSON Input
in an extra `div` (for good reason) which causes all the snapshots of its inner
workings to be indented by an extra level. This causes huge diffs. Seeing as I
will have huge changed in these snapshots anyway I changed them to be shallow
rendered (which they should have been from the start - but better late than
never). This explains the structural nature of the change. You are free to
comment on whether or not you think it is a good idea. (see below)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
