vogievetsky commented on a change in pull request #10271:
URL: https://github.com/apache/druid/pull/10271#discussion_r470077857
##########
File path: web-console/src/components/auto-form/auto-form.spec.tsx
##########
@@ -16,14 +16,14 @@
* limitations under the License.
*/
-import { render } from '@testing-library/react';
+import { shallow } from 'enzyme';
Review comment:
Yup, this changes the virtual rendered from a DOM renderer `import {
render } from '@testing-library/react';` to a shallow react component level
renderer `import { shallow } from 'enzyme';` for the snapshots.
This change makes sense because the auto-form does not really make any of
its own cool DOM it only assembles other components so testing their deep
structure should not be its concern - otherwise it will have structural changes
in the snapshots every-time someone changes the JSON Input
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
