mghosh4 commented on a change in pull request #10373:
URL: https://github.com/apache/druid/pull/10373#discussion_r489569063
##########
File path:
server/src/main/java/org/apache/druid/server/audit/SQLAuditManager.java
##########
@@ -98,6 +98,10 @@ public void doAudit(AuditEntry auditEntry, Handle handle)
throws IOException
.setDimension("key", auditEntry.getKey())
.setDimension("type", auditEntry.getType())
.setDimension("author", auditEntry.getAuditInfo().getAuthor())
+ .setDimension("comment", auditEntry.getAuditInfo().getComment())
+ .setDimension("remote_address", auditEntry.getAuditInfo().getIp())
+ .setDimension("created_date", auditEntry.getAuditTime().toString())
+ .setDimension("payload", auditEntry.getPayload())
Review comment:
@suneet-s Interesting, is this because all the compaction config for
10K+ datasources get generated even when we are updating only 1? Do you think
we can optimize that?
I am fine with making `payload` optional. My only concern is none of the
dimension columns capture the actual change that happened which I believe is
part of `payload`. This is important from the perspective of auditing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
