mghosh4 commented on a change in pull request #10373:
URL: https://github.com/apache/druid/pull/10373#discussion_r486780676
##########
File path:
server/src/main/java/org/apache/druid/server/audit/SQLAuditManager.java
##########
@@ -98,6 +98,10 @@ public void doAudit(AuditEntry auditEntry, Handle handle)
throws IOException
.setDimension("key", auditEntry.getKey())
.setDimension("type", auditEntry.getType())
.setDimension("author", auditEntry.getAuditInfo().getAuthor())
+ .setDimension("comment", auditEntry.getAuditInfo().getComment())
+ .setDimension("remote_address", auditEntry.getAuditInfo().getIp())
+ .setDimension("created_date", auditEntry.getAuditTime().toString())
+ .setDimension("payload", auditEntry.getPayload())
Review comment:
Actually I checked some of the emitter metric logs and it does seem
`payload` has some information not part of other columns. For example, for
`audit_type` `rules` it contains the actual load rule change information,
similarly for `coordinator.config` it contains the config setting. Looking at
this I think I would like to keep the payload information around as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
