suneet-s commented on a change in pull request #10373:
URL: https://github.com/apache/druid/pull/10373#discussion_r489575365
##########
File path:
server/src/main/java/org/apache/druid/server/audit/SQLAuditManager.java
##########
@@ -98,6 +98,10 @@ public void doAudit(AuditEntry auditEntry, Handle handle)
throws IOException
.setDimension("key", auditEntry.getKey())
.setDimension("type", auditEntry.getType())
.setDimension("author", auditEntry.getAuditInfo().getAuthor())
+ .setDimension("comment", auditEntry.getAuditInfo().getComment())
+ .setDimension("remote_address", auditEntry.getAuditInfo().getIp())
+ .setDimension("created_date", auditEntry.getAuditTime().toString())
+ .setDimension("payload", auditEntry.getPayload())
Review comment:
@mghosh4 Yes that's correct. I agree with your concern about the
dimensions not capturing the actual change. I think it's a design flaw of how
audit logging works in general, so we need to address that design holistically.
Right now, even if I look at the `druid_audit` table, I need to do a json
diff to actually know what change happened. I haven't created a proposal on how
to fix that because I haven't had the time to come up with a meaningful
solution to this, and come up with a testing / transition plan so that we don't
break the existing audit logging system.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
