suneet-s commented on a change in pull request #10413:
URL: https://github.com/apache/druid/pull/10413#discussion_r493085850
##########
File path:
indexing-service/src/main/java/org/apache/druid/indexing/common/task/CompactionTask.java
##########
@@ -422,6 +422,7 @@ ParallelIndexSupervisorTask newTask(String taskId,
ParallelIndexIngestionSpec in
{
final Map<String, Object> newContext = new HashMap<>(getContext());
newContext.put(CTX_KEY_APPENDERATOR_TRACKING_TASK_ID, getId());
+ newContext.put(CompactSegments.STORE_COMPACTION_STATE_KEY,
getContextValue(Tasks.STORE_COMPACTION_STATE_KEY, true));
Review comment:
I think you should use putIfAbsent. That will allow the user to provide
a `STORE_COMPACTION_STATE_KEY` that is different from the default value of true
if needed.
Also nit: use a constant for the default value
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
