maytasm commented on a change in pull request #10413:
URL: https://github.com/apache/druid/pull/10413#discussion_r493215560



##########
File path: 
sql/src/main/java/org/apache/druid/sql/calcite/schema/SystemSchema.java
##########
@@ -311,7 +312,8 @@ public TableType getJdbcTableType()
                 val.isOvershadowed() ? IS_OVERSHADOWED_TRUE : 
IS_OVERSHADOWED_FALSE,
                 segment.getShardSpec(),
                 segment.getDimensions(),
-                segment.getMetrics()
+                segment.getMetrics(),
+                segment.getLastCompactionState()

Review comment:
       Both `PartitionsSpec` and `indexSpec` can be helpful in determining the 
cause of query performance issue. We will also want to know what segments auto 
compaction will compact as both of those Spec determine that. 'indexSpec' can 
also impact query performance (see shape shifting PR). 
   
   CompactionState is a small json and is already stored in memory as part of 
the DataSegment. We are also returning the shardSpec so this should not be a 
problem. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to