maytasm opened a new pull request #10413:
URL: https://github.com/apache/druid/pull/10413
Add is_compacted to sys.segments table
### Description
Segments being compacted or not compacted have a big impact on query
performance.
Currently it is not easy to verify questions like:
- if performance of query can be improve by compaction
- if a performance of query is bad, was it because segments for that
interval was not compacted.
This PR expose the information on whether segments is compacted or not via
the sys.segments table (so user can do query with slice/dice, group, time
filter, etc) by using the lastCompactionState stored within the segment
metadata. If a compactionState exist then the segment was compacted. This PR
also change storing lastCompactionState as default for manual compaction in
addition to auto compaction.
This PR has:
- [x] been self-reviewed.
- [ ] using the [concurrency
checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md)
(Remove this item if the PR doesn't have any relation to concurrency.)
- [x] added documentation for new or modified features or behaviors.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked
related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in
[licenses.yaml](https://github.com/apache/druid/blob/master/licenses.yaml)
- [ ] added comments explaining the "why" and the intent of the code
wherever would not be obvious for an unfamiliar reader.
- [x] added unit tests or modified existing tests to cover new code paths,
ensuring the threshold for [code
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
is met.
- [ ] added integration tests.
- [x] been tested in a test Druid cluster.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
