kroeders opened a new pull request #10428:
URL: https://github.com/apache/druid/pull/10428


   ### Description
   
   This PR supports https://github.com/apache/druid/issues/10294 where an issue 
is discussed that queries with lookups may sometimes fail unnecessarily due to 
the lookup only being available on some historicals. The query can succeed by 
avoiding those historicals. In this PR is an extension that tracks lookup 
status on the broker and adds a new ServerSelectorStrategy to avoid historicals 
that are missing required lookups. 
   
   This PR is a small change to make server selection aware of the Query and 
would allow this extension so solve this issue without any other changes in 
core Druid. 
   
   This change just adds Query as a parameter to the ServerSelectorStratey and 
TierSelectorStrategy and provides this parameter in CachingClusteredClient, 
after segments  are found for a query and they are being fanned out across the 
cluster. A default method was added to the interface so existing 
implementations would not need to change. 
   
   <hr>
   
   This PR has:
   - [X] been self-reviewed.
   - [X] added unit tests or modified existing tests to cover new code paths, 
ensuring the threshold for [code 
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
 is met.
   - [ ] been tested in a test Druid cluster.
   
   <hr>
   
   ##### Key changed/added classes in this PR
    * `ServerSelectorStrategy`
    * `TierSelectorStrategy`
    * `CachingClusteredClient`
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to