kroeders commented on a change in pull request #10428:
URL: https://github.com/apache/druid/pull/10428#discussion_r535256895
##########
File path:
server/src/main/java/org/apache/druid/client/CachingClusteredClient.java
##########
@@ -812,7 +812,7 @@ String computeResultLevelCachingEtag(
Hasher hasher = Hashing.sha1().newHasher();
boolean hasOnlyHistoricalSegments = true;
for (SegmentServerSelector p : segments) {
- if (!p.getServer().pick().getServer().isSegmentReplicationTarget()) {
+ if
(!p.getServer().pick(null).getServer().isSegmentReplicationTarget()) {
Review comment:
this was the only functional place that the parameterless pick() was
called that I mentioned in the other comment @jihoonson , the Query is
available inside of SpecificQueryRunnable where this is called, so I could
alternatively pass the query into computeResultLevelCachingEtag and add a null
check on this line, what do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
