kroeders commented on a change in pull request #10428:
URL: https://github.com/apache/druid/pull/10428#discussion_r535246123
##########
File path:
server/src/main/java/org/apache/druid/client/selector/ServerSelector.java
##########
@@ -162,12 +163,20 @@ public boolean isEmpty()
@Nullable
@Override
public QueryableDruidServer pick()
+ {
+ if (!historicalServers.isEmpty()) {
+ return strategy.pick(historicalServers, segment.get());
+ }
+ return strategy.pick(realtimeServers, segment.get());
+ }
+
+ public <T> QueryableDruidServer pick(Query<T> query)
Review comment:
I removed it, the method was called a couple of times in tests (which
seems OK) and in the etag creation part, which seems OK to me. It looks a
little funny to pass in null as a single parameter, but I could argue either
way vs having a method that isn't used elsewhere.
##########
File path:
server/src/main/java/org/apache/druid/client/selector/TierSelectorStrategy.java
##########
@@ -47,6 +49,22 @@
List<QueryableDruidServer> pick(
Int2ObjectRBTreeMap<Set<QueryableDruidServer>> prioritizedServers,
DataSegment segment,
- int numServersToPick
- );
+ int numServersToPick);
+
+ @Nullable
+ default <T> QueryableDruidServer pick(Query<T> query,
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
