suneet-s commented on a change in pull request #10496:
URL: https://github.com/apache/druid/pull/10496#discussion_r502166010
##########
File path: web-console/src/views/datasource-view/datasource-view.tsx
##########
@@ -1011,11 +1006,11 @@ GROUP BY 1`;
),
},
{
- Header: twoLines('Segment size (MB)', 'min / avg / max'),
+ Header: twoLines('Segment size (rows)', 'minimum / average /
maximum'),
show: hiddenColumns.exists('Segment size'),
accessor: 'avg_segment_size',
filterable: false,
- width: 150,
+ width: 220,
Review comment:
Is this wide enough to handle 7 digits for min, avg and max?
From the doc linked in this PR `it's generally recommended for each segment
to have around 5 million rows`
Do you think it's users would want to see a rounded number instead -
something like `2.1M` instead of `2,105,248`
^ just a thought
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
