vogievetsky commented on a change in pull request #10496:
URL: https://github.com/apache/druid/pull/10496#discussion_r502556409
##########
File path: web-console/src/views/datasource-view/datasource-view.tsx
##########
@@ -1011,11 +1006,11 @@ GROUP BY 1`;
),
},
{
- Header: twoLines('Segment size (MB)', 'min / avg / max'),
+ Header: twoLines('Segment size (rows)', 'minimum / average /
maximum'),
show: hiddenColumns.exists('Segment size'),
accessor: 'avg_segment_size',
filterable: false,
- width: 150,
+ width: 220,
Review comment:
I wanted them all to be consistently formatted with the same
abbreviation. So not to have `7.6 M`, `4.3 k`, and `233` all in the same
column. What if we format it as millions with 3 digits:
`5.343 M`, `0.004 M`, `0.000 M`
What do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
