suneet-s commented on a change in pull request #10496:
URL: https://github.com/apache/druid/pull/10496#discussion_r502572389
##########
File path: web-console/src/views/datasource-view/datasource-view.tsx
##########
@@ -1011,11 +1006,11 @@ GROUP BY 1`;
),
},
{
- Header: twoLines('Segment size (MB)', 'min / avg / max'),
+ Header: twoLines('Segment size (rows)', 'minimum / average /
maximum'),
show: hiddenColumns.exists('Segment size'),
accessor: 'avg_segment_size',
filterable: false,
- width: 150,
+ width: 220,
Review comment:
I don't have a strong opinion on this, and will defer to your judgement.
The risk with rounding to millions is that for smaller datasources, it could
always show `0.000 M`
I wonder if the UI could use the largest rounding per datasource. So you
could have something like
```
DS1 5.343 M, 0.004 M, 0.000 M
DS2 0.320 k, 0.120 k, 321.1 k
```
^ even in this example, I'm really confused about how to pick whether to
keep it as `321.1 k` or `0.321 M`
Number formatting isn't my forte 🙃
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
