jihoonson commented on a change in pull request #10335:
URL: https://github.com/apache/druid/pull/10335#discussion_r508821432
##########
File path:
indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/SeekableStreamIndexTaskTuningConfig.java
##########
@@ -84,10 +87,11 @@ public SeekableStreamIndexTaskTuningConfig(
// Cannot be a static because default basePersistDirectory is unique
per-instance
final RealtimeTuningConfig defaults =
RealtimeTuningConfig.makeDefaultTuningConfig(basePersistDirectory);
+ this.appendableIndexSpec = appendableIndexSpec == null ?
DEFAULT_APPENDABLE_INDEX : appendableIndexSpec;
this.maxRowsInMemory = maxRowsInMemory == null ?
defaults.getMaxRowsInMemory() : maxRowsInMemory;
this.partitionsSpec = new DynamicPartitionsSpec(maxRowsPerSegment,
maxTotalRows);
- // initializing this to 0, it will be lazily initialized to a value
- // @see
server.src.main.java.org.apache.druid.segment.indexing.TuningConfigs#getMaxBytesInMemoryOrDefault(long)
+ /** initializing this to 0, it will be lazily initialized to a value
+ * @see #getMaxBytesInMemoryOrDefault() */
Review comment:
Same here.
##########
File path:
indexing-service/src/main/java/org/apache/druid/indexing/common/task/IndexTask.java
##########
@@ -1262,9 +1267,10 @@ private IndexTuningConfig(
@Nullable Integer maxSavedParseExceptions
)
{
+ this.appendableIndexSpec = appendableIndexSpec == null ?
DEFAULT_APPENDABLE_INDEX : appendableIndexSpec;
this.maxRowsInMemory = maxRowsInMemory == null ?
TuningConfig.DEFAULT_MAX_ROWS_IN_MEMORY : maxRowsInMemory;
- // initializing this to 0, it will be lazily initialized to a value
- // @see
server.src.main.java.org.apache.druid.segment.indexing.TuningConfigs#getMaxBytesInMemoryOrDefault(long)
+ /** initializing this to 0, it will be lazily initialized to a value
+ * @see #getMaxBytesInMemoryOrDefault() */
Review comment:
nit: we don't use multi-line comments.
##########
File path: docs/ingestion/index.md
##########
@@ -737,3 +741,11 @@ The `indexSpec` object can include the following
properties:
Beyond these properties, each ingestion method has its own specific tuning
properties. See the documentation for each
[ingestion method](#ingestion-methods) for details.
+
+#### `appendableIndexSpec`
+
+|Field|Description|Default|
+|-----|-----------|-------|
+|type|Each in-memory index has its own tuning type code. You must specify the
type code that matches your in-memory index. Common options are `onheap`, and
`offheap`.|`onheap`|
+
+Beyond these properties, each in-memory index has its own specific tuning
properties.
Review comment:
Do you think if users want to change this config ever for now? I
remember @gianm mentioned that the offheap incremental index has some
performance issue, which is why we don't use it for indexing. If you think this
knob is useful for users, please add more details how each index type is
different and when it's recommended to use what. Otherwise, I would suggest not
documenting this know at least for now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
