liran-funaro commented on a change in pull request #10335:
URL: https://github.com/apache/druid/pull/10335#discussion_r509189589



##########
File path: docs/ingestion/index.md
##########
@@ -737,3 +741,11 @@ The `indexSpec` object can include the following 
properties:
 
 Beyond these properties, each ingestion method has its own specific tuning 
properties. See the documentation for each
 [ingestion method](#ingestion-methods) for details.
+
+#### `appendableIndexSpec`
+
+|Field|Description|Default|
+|-----|-----------|-------|
+|type|Each in-memory index has its own tuning type code. You must specify the 
type code that matches your in-memory index. Common options are `onheap`, and 
`offheap`.|`onheap`|
+
+Beyond these properties, each in-memory index has its own specific tuning 
properties.

Review comment:
       Actually, by @a2l007 suggestion, I deferred the support for offheap 
ingestion to a different PR.
   So this documentation should not include the `offheap` option anyway.
   I'll removed this documentation for now.

##########
File path: docs/ingestion/index.md
##########
@@ -737,3 +741,11 @@ The `indexSpec` object can include the following 
properties:
 
 Beyond these properties, each ingestion method has its own specific tuning 
properties. See the documentation for each
 [ingestion method](#ingestion-methods) for details.
+
+#### `appendableIndexSpec`
+
+|Field|Description|Default|
+|-----|-----------|-------|
+|type|Each in-memory index has its own tuning type code. You must specify the 
type code that matches your in-memory index. Common options are `onheap`, and 
`offheap`.|`onheap`|
+
+Beyond these properties, each in-memory index has its own specific tuning 
properties.

Review comment:
       Actually, by @a2l007 suggestion, I deferred the support for offheap 
ingestion to a different PR.
   So this documentation should not include the `offheap` option anyway.
   I'll remove this documentation for now.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to