liran-funaro commented on a change in pull request #10593:
URL: https://github.com/apache/druid/pull/10593#discussion_r541910843
##########
File path:
processing/src/main/java/org/apache/druid/segment/incremental/OffheapIncrementalIndex.java
##########
@@ -150,18 +150,13 @@ protected AddToFactsResult addToFacts(
boolean skipMaxRowsInMemoryCheck // ignored, we always want to check
this for offheap
) throws IndexSizeExceededException
{
- ByteBuffer aggBuffer;
- int bufferIndex;
- int bufferOffset;
-
synchronized (this) {
final AggregatorFactory[] metrics = getMetrics();
final int priorIndex = facts.getPriorIndex(key);
if (IncrementalIndexRow.EMPTY_ROW_INDEX != priorIndex) {
final int[] indexAndOffset = indexAndOffsets.get(priorIndex);
- bufferIndex = indexAndOffset[0];
- bufferOffset = indexAndOffset[1];
- aggBuffer = aggBuffers.get(bufferIndex).get();
+ ByteBuffer aggBuffer = aggBuffers.get(indexAndOffset[0]).get();
Review comment:
If this bug fix will be in a separate PR, then this PR will have a
failing test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
