lkm commented on a change in pull request #10543:
URL: https://github.com/apache/druid/pull/10543#discussion_r535164826



##########
File path: 
server/src/main/java/org/apache/druid/server/AsyncQueryForwardingServlet.java
##########
@@ -449,6 +463,95 @@ static String getAvaticaConnectionId(Map<String, Object> 
requestMap)
     return (String) connectionIdObj;
   }
 
+  static String getAvaticaProtobufConnectionId(Service.Request request)
+  {
+    if (request instanceof Service.CatalogsRequest) {

Review comment:
       Agreed, it's a bit fragile, however, that, I'm afraid, is the nature of 
protobufs. I'm not sure how likely they are to add new request types without 
significant overhaul to Calcite though




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to