jihoonson commented on a change in pull request #10518:
URL: https://github.com/apache/druid/pull/10518#discussion_r536451667
##########
File path:
processing/src/main/java/org/apache/druid/query/aggregation/GroupingAggregatorFactory.java
##########
@@ -41,6 +41,40 @@
import java.util.Objects;
import java.util.Set;
+/**
+ * This class implements {@code grouping_id} function to determine the
grouping that a row is part of. Different rows
+ * in same result could have different grouping columns when subtotals are
used.
+ *
+ * It takes following arguments
+ * - {@code name} - Name of aggregators
+ * - {code groupings} - List of dimensions that user is interested in tracking
+ * - {@code keyDimensions} - The list of grouping dimensions being included
in the result row. This list is a subset of
+ * {@code groupings0}. This argument cannot be
passed by the user. It is set by druid engine
Review comment:
```suggestion
* {@code groupings}. This argument cannot be
passed by the user. It is set by druid engine
```
##########
File path:
processing/src/main/java/org/apache/druid/query/aggregation/GroupingAggregatorFactory.java
##########
@@ -41,6 +41,40 @@
import java.util.Objects;
import java.util.Set;
+/**
+ * This class implements {@code grouping_id} function to determine the
grouping that a row is part of. Different rows
+ * in same result could have different grouping columns when subtotals are
used.
+ *
+ * It takes following arguments
+ * - {@code name} - Name of aggregators
+ * - {code groupings} - List of dimensions that user is interested in tracking
Review comment:
```suggestion
* - {@code groupings} - List of dimensions that user is interested in
tracking
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
