abhishekagarwal87 commented on a change in pull request #10518:
URL: https://github.com/apache/druid/pull/10518#discussion_r533142242
##########
File path:
processing/src/main/java/org/apache/druid/query/groupby/epinephelinae/RowBasedGrouperHelper.java
##########
@@ -576,7 +594,12 @@ private static ValueExtractFunction
makeValueExtractFunction(
// Add aggregations.
final int resultRowAggregatorStart =
query.getResultRowAggregatorStart();
for (int i = 0; i < entry.getValues().length; i++) {
- resultRow.set(resultRowAggregatorStart + i, entry.getValues()[i]);
+ if (dimsToInclude != null && groupingAggregatorsBitSet.get(i)) {
Review comment:
In the current Long*Aggregator implementations, there is no
serialization/deserialization. Aggregations are no-op and get call just returns
the value passed in the constructor. am I missing any code path here?
I also wanted to limit the places where there is special handling for
`GroupingAggregatorFactory`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
