clintropolis commented on a change in pull request #10518:
URL: https://github.com/apache/druid/pull/10518#discussion_r536457274
##########
File path:
processing/src/main/java/org/apache/druid/query/groupby/epinephelinae/RowBasedGrouperHelper.java
##########
@@ -534,21 +536,45 @@ private static ValueExtractFunction
makeValueExtractFunction(
public static CloseableGrouperIterator<RowBasedKey, ResultRow>
makeGrouperIterator(
final Grouper<RowBasedKey> grouper,
final GroupByQuery query,
- @Nullable final List<String> dimsToInclude,
+ @Nullable final List<DimensionSpec> dimsToInclude,
final Closeable closeable
)
{
final boolean includeTimestamp = query.getResultRowHasTimestamp();
final BitSet dimsToIncludeBitSet = new
BitSet(query.getDimensions().size());
final int resultRowDimensionStart = query.getResultRowDimensionStart();
+ final BitSet groupingAggregatorsBitSet = new
BitSet(query.getAggregatorSpecs().size());
+ final Object[] groupingAggregatorValues = new
Long[query.getAggregatorSpecs().size()];
if (dimsToInclude != null) {
- for (String dimension : dimsToInclude) {
- final int dimIndex = query.getResultRowSignature().indexOf(dimension);
+ for (DimensionSpec dimensionSpec : dimsToInclude) {
+ String outputName = dimensionSpec.getOutputName();
+ final int dimIndex = query.getResultRowSignature().indexOf(outputName);
if (dimIndex >= 0) {
dimsToIncludeBitSet.set(dimIndex - resultRowDimensionStart);
}
}
+
+ /**
Review comment:
nit: javadoc comment format on inline comment
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
