gianm commented on a change in pull request #10758:
URL: https://github.com/apache/druid/pull/10758#discussion_r558087569
##########
File path:
processing/src/test/java/org/apache/druid/segment/filter/FilterCnfConversionTest.java
##########
@@ -356,65 +356,65 @@ public void
testToNormalizedOrClausesWithComplexFilterIncludingNotAndOr()
)
)
);
- final Set<Filter> expected = ImmutableSet.of(
+ final List<Filter> expected = ImmutableList.of(
Review comment:
Another note: these were also just reorderings.
##########
File path:
processing/src/test/java/org/apache/druid/segment/filter/FilterCnfConversionTest.java
##########
@@ -253,54 +253,54 @@ public void testToCnfWithComplexFilterIncludingNotAndOr()
)
);
final Filter expected = FilterTestUtils.and(
+ // The below OR filter could be eliminated because this filter also has
Review comment:
Note: these result changes were just re-orderings.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
