gianm commented on a change in pull request #10758:
URL: https://github.com/apache/druid/pull/10758#discussion_r558088939
##########
File path:
processing/src/test/java/org/apache/druid/segment/join/JoinFilterAnalyzerTest.java
##########
@@ -2545,18 +2545,10 @@ public void
test_filterPushDown_factToRegionToCountryLeftFilterOnTwoRHSColumnsSa
JoinFilterSplit expectedFilterSplit = new JoinFilterSplit(
new AndFilter(
ImmutableList.of(
- new AndFilter(
- ImmutableList.of(
- new InDimFilter("countryIsoCode",
ImmutableSet.of("MMMM", "AAAA"), null, null).toFilter(),
- new InDimFilter("regionIsoCode",
ImmutableSet.of("MMMM", "AAAA"), null, null).toFilter()
- )
- ),
- new AndFilter(
- ImmutableList.of(
- new InDimFilter("countryIsoCode",
ImmutableSet.of("US"), null, null).toFilter(),
- new InDimFilter("regionIsoCode",
ImmutableSet.of("CA"), null, null).toFilter()
- )
- )
+ new InDimFilter("countryIsoCode", ImmutableSet.of("US"), null,
null).toFilter(),
Review comment:
This rewrite got better!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
