suneet-s commented on a change in pull request #10758:
URL: https://github.com/apache/druid/pull/10758#discussion_r558805842
##########
File path:
processing/src/main/java/org/apache/druid/query/filter/BooleanFilter.java
##########
@@ -23,13 +23,14 @@
import org.apache.druid.segment.ColumnSelectorFactory;
import java.util.HashSet;
+import java.util.List;
import java.util.Set;
public interface BooleanFilter extends Filter
{
ValueMatcher[] EMPTY_VALUE_MATCHER_ARRAY = new ValueMatcher[0];
- Set<Filter> getFilters();
+ List<Filter> getFilters();
Review comment:
Could you add a javadoc to this function explaining why we a list is
used here so that we can preserve the order of the filters to enable
short-circuiting.
Writing out this comment, made me think perhaps we could achieve the same
outcome by using a LinkedHashSet instead - that would make it clearer in the
rest of the code that there are no duplicates in the filters
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
