clintropolis commented on a change in pull request #10613:
URL: https://github.com/apache/druid/pull/10613#discussion_r553845596
##########
File path:
processing/src/main/java/org/apache/druid/query/dimension/DimensionSpec.java
##########
@@ -70,6 +71,11 @@ default MultiValueDimensionVectorSelector
decorate(MultiValueDimensionVectorSele
throw new UOE("DimensionSpec[%s] cannot vectorize", getClass().getName());
}
+ default VectorObjectSelector decorate(VectorObjectSelector selector)
Review comment:
This is used with the poorly named
`VectorColumnSelectorFactory.makeStringObjectSelector`, which should be renamed
`VectorColumnSelectorFactory.makeDimensionObjectSelector` or something, which
is for doing dimensiony things with a vector object selector similar to what is
done for `SingleValueDimensionVectorSelector` or
`MultiValueDimensionVectorSelector`. There are currently no implementations of
this, like is the case with the other decorate methods with vector selectors, i
was just trying for symmetry here so that the object selector could behave
similar to the other string selectors when used in this context
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
