gianm commented on a change in pull request #10758:
URL: https://github.com/apache/druid/pull/10758#discussion_r560756535
##########
File path:
processing/src/main/java/org/apache/druid/query/filter/BooleanFilter.java
##########
@@ -23,13 +23,14 @@
import org.apache.druid.segment.ColumnSelectorFactory;
import java.util.HashSet;
+import java.util.List;
import java.util.Set;
public interface BooleanFilter extends Filter
{
ValueMatcher[] EMPTY_VALUE_MATCHER_ARRAY = new ValueMatcher[0];
- Set<Filter> getFilters();
+ List<Filter> getFilters();
Review comment:
I think doing the LinkedHashSet makes sense, so I went with that
approach. It simplified the code a bit, and let me delete the
EquivalenceCheckedFilter stuff.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
