clintropolis commented on pull request #10880: URL: https://github.com/apache/druid/pull/10880#issuecomment-780203378
>@clintropolis wanted to check in and get your thoughts on the integration tests checkbox being there but unchecked. I don't want to merge before you push a test if that is what you plan on doing! But I can merge if you feel that you are not going to push anymore testing or update the the nit comment on readability of the javadoc Ah, sorry for the delay, have been swamped. I wasn't planning on adding an integration test at this time since I'm not entirely sure it would add much that the existing unit/functional-ish tests cover, but i was going to adjust the javadoc as well as rework the documentation to be a bit clearer, so will add the WIP label ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
