clintropolis commented on a change in pull request #10880:
URL: https://github.com/apache/druid/pull/10880#discussion_r574848417
##########
File path:
sql/src/test/java/org/apache/druid/sql/avatica/DruidAvaticaHandlerTest.java
##########
@@ -918,6 +918,107 @@ public Frame fetch(
);
}
+
+ @Test
+ public void testMinRowsPerFrame() throws Exception
Review comment:
Yep, the [statement sets a fetch size of
2](https://github.com/apache/druid/pull/10880/files#diff-5430fa325aa463d4b6c34cad0fa3816e30e189ad2e3d7dbf56567c60e9c6c785R1004),
but the min is 1000, so prior to this patch this test would fail because it
would take multiple frames (and it also explicitly checks that fetch is called
with the adjusted minimum value here
https://github.com/apache/druid/pull/10880/files#diff-5430fa325aa463d4b6c34cad0fa3816e30e189ad2e3d7dbf56567c60e9c6c785R978)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
